-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.torchWithRocm: fix build #298609
Conversation
Maybe the correct fix for now is to switch to |
I tried switching back to
I can fix this like so (not sure if it should be in
But, then it's complaining about not finding At the same time it does not seem like upstream torch supports ROCm 6.0 already. |
The The branch for it is here: master...mschwaig:nixpkgs:fix-torch-with-rocm-2 |
8400be6
to
45437c9
Compare
Actually I found out that those runtime errors involving So the right solution for now should be to go back to I'm running |
Result of 3 packages marked as broken and skipped:
3 packages failed to build:
10 packages built:
|
347c3be
to
45437c9
Compare
Result of 6 packages marked as broken and skipped:
3 packages failed to build:
10 packages built:
|
Can we split this into 2 PRs? One for pytorch and one for deprecated packages. I don't see why they should be in the same one. If you do that we can merge both quickly 😊 or if you can give a compelling reason |
45437c9
to
1c92ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description of changes
torchWithRocm
fails to build, since we merged ROCm 6.0 (#287846).This PR
together with #298451should fix that.I am still in the process of building this fix locally, to see if it works.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.